Mostly copy in .gitattributes from master#84
Merged
JeroenDeDauw merged 2 commits intoDataValues:0.4.xfrom Sep 24, 2019
Merged
Conversation
Member
|
Master has it wrong. tests/ cannot be excluded since it is (unfortunately) not fully package private. https://github.com/DataValues/Common/blob/master/composer.json#L47 |
Member
|
Master fix: #85 |
Contributor
Author
What do you mean? Tests shouldn't be needed when installing via composer... |
Member
|
There is a test base class used by other packages. Bad design from 2012 says hello. https://github.com/DataValues/Common/blob/master/tests/ValueParsers/ValueParserTestBase.php |
Member
|
Been removing code using shit like this for years. This base class still has some users. Help with killing those is welcome |
JeroenDeDauw
added a commit
that referenced
this pull request
Sep 20, 2019
Allows for #84 Wikibase Repo has 3 usages of StringValueParserTest: https://github.com/wikimedia/mediawiki-extensions-Wikibase/search?q=StringValueParserTest These can easily be fixed by using a copy of the class (or better yet: refactoring away from this inheritance abuse pattern).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.